Skip to content

fix: handle invalid orgID with proper 400 error #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle invalid orgID with proper 400 error #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/api-gateway/src/webhook/dtos/get-webhoook-dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import { trim } from '@credebl/common/cast.helper';
@ApiExtraModels()
export class GetWebhookDto {

@ApiPropertyOptional({example: '2a041d6e-d24c-4ed9-b011-1cfc371a8b8e'})
@IsOptional()
@ApiProperty({example: '2a041d6e-d24c-4ed9-b011-1cfc371a8b8e'})
@Transform(({ value }) => trim(value))
@IsNotEmpty({ message: 'Please provide the valid orgID' })
@IsString({ message: 'Organization id must be in string format.' })
orgId?: string;
orgId: string;
Comment on lines +9 to +13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still try keeping the value optional as it is. Ideally this should be causing an issue.


@ApiPropertyOptional({example: '3a041d6e-d24c-4ed9-b011-1cfc371a8b8e'})
@IsOptional()
Expand Down
1 change: 1 addition & 0 deletions platform
Open in desktop
Submodule platform added at ea4d5f