-
Notifications
You must be signed in to change notification settings - Fork 73
merge: DEV to QA #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
merge: DEV to QA #1381
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
855603d
feat: refactor agent endpoint for token (#1375)
tipusinghaw 255236a
refactor: changes agent endpoint (#1378)
tipusinghaw 2593951
refactore: schema id in get schema (#1379)
tipusinghaw 9deb93a
refactor: token API for tenant and create keypair (#1380)
tipusinghaw b45186f
feat: update workflow file to build and push multi-architecture Docke…
KambleSahil3 4481091
fix: DCO remediation ability (#1382)
GHkrishna 732ac88
feat: added env key in sample and demo file (#1384)
tipusinghaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| allowRemediationCommits: | ||
| individual: true | ||
| thirdParty: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
Copilot Autofix
AI 6 months ago
To fix the problem, we should avoid constructing a shell command as a single string and passing it to
exec. Instead, we should useexecFile(orexecFileSyncif synchronous execution is desired), which allows us to specify the command and its arguments separately. This prevents shell interpretation of arguments and mitigates the risk of shell injection.Detailed steps:
execFileto run the shell script, passing the arguments as an array.apps/agent-provisioning/src/agent-provisioning.service.tsat lines 43–45 to useexecFileinstead ofexec.execFileis part of Node.js'schild_processmodule.