Skip to content

Conversation

@sujitaw
Copy link
Contributor

@sujitaw sujitaw commented Nov 21, 2025

What

  • Increased the timeout for uploaded csv file for issuance to stay longer in the cache from 1 min to 15 min.

Summary by CodeRabbit

  • Chores
    • Updated cache retention duration to improve performance and reduce database load.

✏️ Tip: You can customize this high-level summary in your review settings.

@sujitaw sujitaw requested a review from shitrerohit November 21, 2025 07:58
@sujitaw sujitaw self-assigned this Nov 21, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2025

Walkthrough

The default cache TTL constant in the CommonConstants enum has been increased from 60000 milliseconds (60 seconds) to 900000 milliseconds (15 minutes). A clarifying comment documenting that the value is in milliseconds has been added.

Changes

Cohort / File(s) Summary
Cache TTL Configuration
libs/common/src/common.constant.ts
Updated DEFAULT_CACHE_TTL enum member from 60000 to 900000; added clarifying comment about millisecond unit

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward constant value update with minimal scope—a single enum member modification and documentation comment addition requiring no logic verification.

Poem

🐰 The cache now lingers, fifteen minutes deep,
Where secrets of data peacefully sleep,
From sixty to nine-hundred-thousand we leap,
A millisecond marvel, the promise we keep! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: increasing Redis timeout for uploaded CSV files during issuance, which directly corresponds to the DEFAULT_CACHE_TTL update (60000ms to 900000ms = 1 to 15 minutes).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/redis_timeout_for_uploaded_csv

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ffcd2f1 and 8132328.

📒 Files selected for processing (1)
  • libs/common/src/common.constant.ts (1 hunks)
🔇 Additional comments (1)
libs/common/src/common.constant.ts (1)

206-207: The constant scope is correctly limited to CSV file uploads—no unintended effects.

Verification confirms DEFAULT_CACHE_TTL is used exclusively at apps/issuance/src/issuance.service.ts:1376 as a fallback for file upload caching. The change from 1 minute to 15 minutes aligns with the PR's intent and won't affect other cache operations. The FILEUPLOAD_CACHE_TTL environment variable provides deployment-level control if different TTLs are needed.

The constant name is appropriately generic as it serves as a fallback default. The change is safe to merge.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants