Resolved fav icon issue and support multiple fav icon

[sanjaykhondal-aw]

WHAT

• Changed favicon and page title based on the selected theme.
• Resolved the issue with collapsible icons not displaying correctly.

---

Important

Introduces dynamic favicon and title updates based on theme and fixes collapsible icon display issues.

• Behavior:
  • Introduces FaviconUpdater component to dynamically update favicon and page title based on theme in layout.tsx.
  • Fixes collapsible icon display issue by changing SVG fill to currentColor in iconsSvg.tsx.
• Components:
  • Adds FaviconUpdater to layout.tsx to handle theme-based favicon and title updates.
  • Updates ThemeSelector to change favicon and title on theme change.
  • Modifies AppSidebar to use new favicon paths for collapsed logos.
• Misc:
  • Updates AlertComponent usage in Credentials.tsx to handle error messages more gracefully.

^{This description was created by for 23a6666. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 23a6666 in 43 seconds. Click for details.

• Reviewed 210 lines of code in 6 files
• Skipped 4 files when reviewing.
• Skipped posting 6 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. nextjs/src/app/layout.tsx:66

• Draft comment:
  Ensure the default favicon fallback does not conflict with dynamic updates provided by FaviconUpdater.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. nextjs/src/components/FaviconUpdater.tsx:7

• Draft comment:
  Consider using a robust cookie parser instead of a regex to extract cookie values for improved reliability.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

3. nextjs/src/components/iconsSvg.tsx:11

• Draft comment:
  Using 'currentColor' for icon fill improves theming consistency. Verify that this change meets design expectations.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

4. nextjs/src/components/layout/app-sidebar.tsx:56

• Draft comment:
  Updated collapsedLogoImageSrc now refers to the correct favicon paths. Ensure these image assets exist.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

5. nextjs/src/components/theme-selector.tsx:17

• Draft comment:
  There is duplicated favicon and title update logic here and in FaviconUpdater. Consider centralizing this behavior.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

6. nextjs/src/features/organization/connectionIssuance/components/Credentials.tsx:269

• Draft comment:
  The simplified AlertComponent usage is cleaner; ensure error values are consistently converted to strings to avoid unexpected types.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_jp3WhgnEAKWT5Exw

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud