Skip to content

Fix: button alert#1032

Merged
sanjaykhondal-aw merged 3 commits intodevelop-nextjsfrom
fix/button-alert
Jun 13, 2025
Merged

Fix: button alert#1032
sanjaykhondal-aw merged 3 commits intodevelop-nextjsfrom
fix/button-alert

Conversation

@sanjaykhondal-aw
Copy link
Contributor

@sanjaykhondal-aw sanjaykhondal-aw commented Jun 13, 2025

WHAT

  • No error message displayed for invalid password during login.
  • Resolved-When the owner updates an organization’s role to both Issuer and Verifier, only one role (either Issuer or Verifier) is displayed in the Organization list. It should display both roles if assigned.
  • Inconsistent display of arrows on buttons across the application.
    -Issue button disabled for “Issuer Role” on Issuance list page.
    -“user and invitation” tab labels should be updated to display "User" and "Invitation" with uppercase U and I.

image
image
image
image


Important

Fixes UI inconsistencies and error handling across multiple components, including user-auth-form.tsx, OrganizationList.tsx, and Members.tsx.

  • Behavior:
    • Display error message for invalid password in user-auth-form.tsx.
    • Show both Issuer and Verifier roles in OrganizationList.tsx.
    • Enable "Issue" button for "Issuer Role" in Issuance.tsx.
  • UI Consistency:
    • Replace CircleArrowRight with ArrowRight in Connections.tsx, Issuance.tsx, CredDefSelection.tsx, EmailAttributesSelection.tsx, EmailCredDefSelection.tsx, and VerificationSchemasList.tsx.
    • Update text color for error messages in DedicatedAgentForm.tsx.
    • Capitalize "User" and "Invitation" in Members.tsx.
  • Misc:
    • Minor logging changes in user-auth-form.tsx.

This description was created by Ellipsis for 926cd6a. You can customize this summary. It will automatically update as commits are pushed.

Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 926cd6a in 46 seconds. Click for details.
  • Reviewed 265 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. nextjs/src/features/wallet/DedicatedAgentForm.tsx:109
  • Draft comment:
    Avoid placeholder functions that throw errors in DedicatedLedgerConfig props. Replace the dummy setLedgerConfig and onConfigureDedicated functions with proper implementations.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. nextjs/src/features/wallet/DedicatedAgentForm.tsx:113
  • Draft comment:
    Passing 'undefined' to setAgentConfig can lead to runtime errors. Ensure a valid function or value is provided.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_Ayvg4KHABK7erAYZ

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@sonarqubecloud
Copy link

@ajile-in ajile-in changed the title Fix/button alert Fix: button alert Jun 13, 2025
@sanjaykhondal-aw sanjaykhondal-aw merged commit 3a6b55a into develop-nextjs Jun 13, 2025
6 of 7 checks passed
@pranalidhanavade pranalidhanavade deleted the fix/button-alert branch September 19, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants