Merged
Conversation
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 926cd6a in 46 seconds. Click for details.
- Reviewed
265lines of code in10files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. nextjs/src/features/wallet/DedicatedAgentForm.tsx:109
- Draft comment:
Avoid placeholder functions that throw errors in DedicatedLedgerConfig props. Replace the dummy setLedgerConfig and onConfigureDedicated functions with proper implementations. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. nextjs/src/features/wallet/DedicatedAgentForm.tsx:113
- Draft comment:
Passing 'undefined' to setAgentConfig can lead to runtime errors. Ensure a valid function or value is provided. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_Ayvg4KHABK7erAYZ
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
shitrerohit
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



WHAT
-Issue button disabled for “Issuer Role” on Issuance list page.
-“user and invitation” tab labels should be updated to display "User" and "Invitation" with uppercase U and I.
Important
Fixes UI inconsistencies and error handling across multiple components, including
user-auth-form.tsx,OrganizationList.tsx, andMembers.tsx.user-auth-form.tsx.OrganizationList.tsx.Issuance.tsx.CircleArrowRightwithArrowRightinConnections.tsx,Issuance.tsx,CredDefSelection.tsx,EmailAttributesSelection.tsx,EmailCredDefSelection.tsx, andVerificationSchemasList.tsx.DedicatedAgentForm.tsx.Members.tsx.user-auth-form.tsx.This description was created by
for 926cd6a. You can customize this summary. It will automatically update as commits are pushed.