[Draft]: SSO using nextauth#1045
Closed
bhavanakarwade wants to merge 20 commits intodevelop-nextjsfrom
Closed
Conversation
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to e09bef2 in 2 minutes and 13 seconds. Click for details.
- Reviewed
620lines of code in19files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. nextjs/src/features/auth/components/user-auth-form.tsx:84
- Draft comment:
Typo in query parameter: 'clienAlias' should be 'clientAlias'. - Reason this comment was not posted:
Marked as duplicate.
2. nextjs/src/features/wallet/SetPrivateKeyValue.tsx:78
- Draft comment:
Ensure consistent private key format. The check for length 64 may not account for a 0x-prefix. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. nextjs/src/utils/authOptions.ts:74
- Draft comment:
Possible typo in API route. 'sinIn' might be intended as 'signIn'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. nextjs/src/utils/authOptions.ts:62
- Draft comment:
The credentials provider includes an unused 'isPasskey' field. Consider removing it if not needed. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. nextjs/src/features/organization/connectionIssuance/components/ConnectionList.tsx:125
- Draft comment:
Consider using a controlled checkbox instead of defaultChecked for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. nextjs/src/features/auth/components/SignUpUser.tsx:20
- Draft comment:
Typo: The query parameter string uses 'clienAlias' instead of 'clientAlias'. - Reason this comment was not posted:
Marked as duplicate.
7. nextjs/src/utils/authOptions.ts:74
- Draft comment:
Typographical error: It appears that 'sinIn' may be a typo. Should it be 'signIn' for the authentication endpoint? - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_Y8ZJ9bHNd5aqil8o
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Signed-off-by: Ajay Jadhav <ajay@ayanworks.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Signed-off-by: Ajay Jadhav <ajay@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
* fix/issuance card and color fix Signed-off-by: Sujit <sujit.sutar@ayanworks.com> * fix/ added minor fix Signed-off-by: Sujit <sujit.sutar@ayanworks.com> * fix : alert component issue error handling Signed-off-by: Sujit <sujit.sutar@ayanworks.com> * fix: ellipse comment Signed-off-by: Sujit <sujit.sutar@ayanworks.com> --------- Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
* refactor: user profile section and developers setting page Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: organization already exist issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve: ellipsis comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve: ellipsis comments on pull request Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * developers settingUI rendering issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * developers settings rendering issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: changes for avatar component colors Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: svg changes for key icon on developer setting Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: developers setting page Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: user profile section and developers setting page Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * revert: icon issue for dedicated agent ledger icons Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * removed extra code Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: setup wallet later button issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
* fix: organization breadcrumb issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * dedicated agent ledger icons Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve: sonarcloud issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: common validation function for ledger config validations Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: passkey in profile section Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: ellipse comments Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
Signed-off-by: sanjaykhondal-aw <sanjay.khondal@ayanworks.com>
* fix: UI fixes for sign up page Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: ellips suggestions on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: issues in profile section Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: ellipsis comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: ellipsis comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 784f405 in 28 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. nextjs/src/features/profile/components/EditUserProfile.tsx:274
- Draft comment:
Extra newline added. If this spacing is intentional for readability, it's fine; otherwise, consider removing unnecessary whitespace. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_QLFjaY9qGMuSDz7y
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Important
Introduces SSO using NextAuth with redirect handling and updates authentication components to support
redirectToandclientAlias.authOptionswith redirect handling.EmailVerificationForm,SignUpUser,UserInfoForm,VerifyEmail, anduser-auth-formto handleredirectToandclientAliasparameters.SessionCheckto manage session redirects based onredirectTo.sendVerificationMailinAuth.tsto useclientAliasinstead ofclientIdandclientSecret.Modal.tsxto improve code formatting.PasswordSuggestionBox.tsxfor better styling.authSlice.tsandauthOptions.tsfor session token management.OrganizationDashboard,CreateOrganizationModal, andWalletSpinupComponentto handleredirectToandclientAlias.This description was created by
for 784f405. You can customize this summary. It will automatically update as commits are pushed.