Skip to content

Fixed searching functionality for schemalist #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sujitaw merged 4 commits into from
Jun 26, 2025
Merged

Fixed searching functionality for schemalist #1054

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14fa7a8
fix/search functionality for schema list page
sujitaw Jun 26, 2025
45493b5
fix/ sonar cube issue
sujitaw Jun 26, 2025
b90f71b
fix/pagination issue of last page being blank
sujitaw Jun 26, 2025
72d36ec
fix/ ellipse comment
sujitaw Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions nextjs/src/features/schemas/components/SchemaList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ const SchemaList = (props: {
if (organizationId) {
getSchemaList(schemaListAPIParameter, allSchemaFlag)
}
}, [schemaListAPIParameter.page])
}, [schemaListAPIParameter.page, schemaListAPIParameter.allSearch, schemaListAPIParameter.search])

const onSearch = (event: ChangeEvent<HTMLInputElement>): void => {
const inputValue = event.target.value
Expand Down Expand Up @@ -426,7 +426,7 @@ const SchemaList = (props: {
</Button>
</div>

{loading ? (
{loading && (
<div className="grid grid-cols-1 gap-4 sm:grid-cols-2 lg:grid-cols-2">
{[...Array(4)].map((_, idx) => (
<div key={idx} className="space-y-3 rounded-lg p-4 shadow-sm">
Expand All @@ -438,7 +438,9 @@ const SchemaList = (props: {
</div>
))}
</div>
) : schemaList.length ? (
)}

{loading ? null : schemaList.length ? (
<>
<div className="grid grid-cols-1 gap-4 sm:grid-cols-2 lg:grid-cols-2">
{schemaList.map((element) => (
Expand All @@ -464,7 +466,7 @@ const SchemaList = (props: {
</div>
))}
</div>
{totalItem > itemPerPage && (
{totalItem > itemPerPage && schemaList.length === itemPerPage && (
<div className="mt-6 flex justify-end">
<Pagination className="m-0 w-fit">
<PaginationContent>
Expand Down
Loading