Skip to content

Conversation

@pranalidhanavade
Copy link
Contributor

@pranalidhanavade pranalidhanavade commented Jul 16, 2025

What

  • UI changes for user profile and edit user profile.

UI screens

profile_edit_11 profile_11 developers_11

Important

UI updates for user profile components, including avatar color changes, layout improvements, and integration of edit profile into a sheet for better UX.

  • UI Changes:
    • Updated avatar background and text colors in globals.css.
    • Wrapped UserProfile component in PageContainer in profile/page.tsx.
    • Removed shadow from Card components in CredentialDefinition.tsx, OrganizationCardList.tsx, RecentActivity.tsx, and SchemasList.tsx.
    • Updated RecentActivity.tsx to use muted text color for "No recent activity found." message.
  • Profile Components:
    • Refactored DisplayUserProfile.tsx to include RecentActivity and reorganized layout.
    • Updated EditUserProfile.tsx to use a sticky footer for Save/Cancel buttons.
    • Integrated EditUserProfile into a Sheet component in UserProfile.tsx for better UX.
  • Miscellaneous:
    • Simplified CreateOrganizationModal.tsx by removing redundant form validation logic.
    • Adjusted padding and border styles in AddPasskey.tsx.

This description was created by Ellipsis for 73c1586. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 13e8a3e in 2 minutes and 7 seconds. Click for details.
  • Reviewed 1562 lines of code in 17 files
  • Skipped 0 files when reviewing.
  • Skipped posting 8 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. nextjs/src/features/profile/components/EditUserProfile.tsx:238
  • Draft comment:
    Consider using 'innerRef' (with a capital 'R') instead of 'innerref' on the Formik Field to ensure the ref is forwarded correctly.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. nextjs/src/features/wallet/WalletSpinupComponent.tsx:305
  • Draft comment:
    Use router.push() instead of setting window.location.href to maintain Next.js SPA navigation behavior.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. nextjs/src/features/wallet/WalletSpinupComponent.tsx:393
  • Draft comment:
    Consider abstracting the socket event listener registration into a custom hook to separate concerns and improve readability.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. nextjs/src/features/profile/components/UserProfile.tsx:117
  • Draft comment:
    Consider conditionally rendering the edit profile Sheet only when editing is active rather than always rendering it, to avoid unnecessary component overhead.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% Modern UI libraries like this typically handle mounting/unmounting efficiently through their open prop. The Sheet likely has internal optimizations. The current approach using open prop is actually a common pattern for modal/drawer components to maintain state and animations. Conditional rendering could cause animation issues or state reset problems. I might be underestimating the performance impact of keeping the Sheet mounted. The component could be heavy and impact initial load time. The performance impact would likely be negligible since it's a single component, and the current approach using open prop is more robust for animations and state management. The comment should be deleted as it suggests changing a valid pattern that likely works better for animations and state management, without clear evidence of performance issues.
5. nextjs/src/features/wallet/LedgerConfig.tsx:602
  • Draft comment:
    Since the button's type is 'submit', the explicit onClick handler calling formikHandlers.handleSubmit() is redundant. Consider removing it.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. nextjs/src/features/wallet/LedgerConfig.tsx:519
  • Draft comment:
    The wallet label field is rendered in two different conditional branches. Consider refactoring to avoid duplicating the UI fragment for better maintainability.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. nextjs/src/features/wallet/WalletSpinupComponent.tsx:412
  • Draft comment:
    Consider extracting the sessionStorage logic (loading, saving, clearing spinup status) into a custom hook to improve clarity and reusability.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. nextjs/src/features/wallet/LedgerConfig.tsx:31
  • Draft comment:
    Typo Notice: The import for SetPrivateKeyValueInput is from './SetPrivateKeyValue', which may be missing the 'Input' suffix. Please verify if the file name is correct or if it should be './SetPrivateKeyValueInput'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_Dg5ilcaIBfsFTuQ2

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@sujitaw sujitaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Signed-off-by: pranalidhanavade <[email protected]>
@sonarqubecloud
Copy link

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 73c1586 in 1 minute and 13 seconds. Click for details.
  • Reviewed 38 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. nextjs/src/features/profile/components/EditUserProfile.tsx:18
  • Draft comment:
    Imported Loader component – verify that the Loader is available and styled as intended.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. nextjs/src/features/profile/components/EditUserProfile.tsx:280
  • Draft comment:
    Sticky footer container now uses flex and flex-col along with gap-2 and space-y-2. Consider if both gap-2 and space-y-2 are needed or if one can be removed for consistency.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. nextjs/src/features/profile/components/EditUserProfile.tsx:282
  • Draft comment:
    Removal of the 'form' attribute from the submit Button is acceptable if it's nested inside the Form element. Confirm it still triggers form submission as expected.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
4. nextjs/src/features/profile/components/EditUserProfile.tsx:285
  • Draft comment:
    Replacing 'Saving...' text with a Loader component improves UI feedback. Ensure the Loader's sizing and alignment integrate well within the button.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_UstRhhTiUgLHVmQw

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@pranalidhanavade pranalidhanavade changed the title Fix/org flow UI changes Fix: Org flow UI changes Jul 17, 2025
@pranalidhanavade pranalidhanavade merged commit 05b5516 into develop-nextjs Jul 17, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet