Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Test optional dependencies are not required in runtime#260

Merged
vinibrsl merged 3 commits intomainfrom
optional-deps-test
Apr 8, 2025
Merged

Test optional dependencies are not required in runtime#260
vinibrsl merged 3 commits intomainfrom
optional-deps-test

Conversation

@vinibrsl
Copy link
Member

@vinibrsl vinibrsl commented Apr 8, 2025

  • Tests optional dependencies being required in runtime, preventing future ImportErrors in next cuts
  • Fixes a current issue with boto3 being required in runtime
  • Adds CI pipeline

@vinibrsl vinibrsl marked this pull request as ready for review April 8, 2025 16:00
@vinibrsl vinibrsl force-pushed the optional-deps-test branch 3 times, most recently from 3f39231 to 61cedee Compare April 8, 2025 16:38
@vinibrsl vinibrsl force-pushed the optional-deps-test branch from 61cedee to 97b51d9 Compare April 8, 2025 16:40
Comment on lines +92 to +97
try:
import boto3
from botocore.exceptions import ClientError
except ImportError:
raise ImportError("`boto3` package not found, please run `uv add boto3`")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this. this is the standard for adding optional dependencies!

@vinibrsl vinibrsl merged commit 303cf05 into main Apr 8, 2025
1 check passed
@vinibrsl vinibrsl deleted the optional-deps-test branch April 8, 2025 17:20
mplachta pushed a commit to mplachta/crewAI-tools that referenced this pull request Aug 27, 2025
* Test optional dependencies are not required in runtime

* Add dynamic imports to S3 tools

* Setup CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants