Fixed JSON formatting #3475
Fixed JSON formatting #3475
Conversation
|
Before After |
| sources_branch = None | ||
|
|
||
| # Try to find an existing "Sources Used" branch | ||
| for sub_child in child.children: | ||
| if "Sources Used" in str(sub_child.label): | ||
| sources_branch = sub_child | ||
| break | ||
| else: | ||
| sources_branch = child.add("Sources Used") | ||
| sources_branch.add(f"✅ {memory_type} ({query_time_ms:.2f}ms)") | ||
| break | ||
|
|
||
| # If not found, create it under this child | ||
| if sources_branch is None: | ||
| sources_branch = child.add("🧠 Sources Used") | ||
|
|
||
| sources_branch.add(f"✅ {memory_type} ({query_time_ms:.2f}ms)") | ||
| break | ||
|
|
There was a problem hiding this comment.
This is was a logic change done, because of linter.
| sources_branch = None | ||
|
|
||
| # Try to find an existing "Sources Used" branch | ||
| for sub_child in child.children: | ||
| if "Sources Used" in str(sub_child.label): | ||
| sources_branch = sub_child | ||
| break | ||
| else: | ||
|
|
||
| # If not found, create it under this child | ||
| if sources_branch is None: | ||
| sources_branch = child.add("🧠 Sources Used") | ||
| sources_branch.add(f"❌ {memory_type} - Error: {error}") | ||
| break | ||
|
|
||
| sources_branch.add(f"❌ {memory_type} - Error: {error}") | ||
| break | ||
|
|
There was a problem hiding this comment.
This one as well
|
Requesting @lorenzejay, @lucasgomide for review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| sources_branch.add(f"✅ {memory_type} ({query_time_ms:.2f}ms)") | ||
| break | ||
|
|
There was a problem hiding this comment.
Bug: Memory Query Handling Fails
The refactored logic in handle_memory_query_completed and handle_memory_query_failed incorrectly replaces the for...else construct. The sources_branch variable is reassigned to each inner_child during iteration, making the subsequent if sources_branch is None: check ineffective. This leads to new memory entries being added to the wrong child when no "Sources Used" branch is found, or duplicated if one is found and updated.
Additional Locations (1)
| def __init__(self, verbose: bool = False): | ||
| self.console = Console(width=None) | ||
| self.verbose = verbose | ||
| self.tool_usage_counts: dict[str, int] = {} |
There was a problem hiding this comment.
Bug: Instance Variable Shadows Class Variable
The tool_usage_counts instance variable, initialized in __init__, shadows the class variable of the same name. This prevents tool usage from being tracked globally across all instances, leading to each instance having its own isolated count instead of a shared one.
1 participant
This fixes the tool input console formatting
Fixes #3474