Skip to content

explicitly set unspecified name id format #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quantumsheep wants to merge 2 commits into
base: main
Choose a base branch
from
Open

explicitly set unspecified name id format #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc70c35
explicitly set unspecified name id format
quantumsheep Sep 3, 2025
e7f4926
update test
quantumsheep Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions service_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,8 +1614,6 @@ func (sp *ServiceProvider) nameIDFormat() string {
case "":
// To maintain library back-compat, use "transient" if unset.
nameIDFormat = string(TransientNameIDFormat)
case UnspecifiedNameIDFormat:
// Spec defines an empty value as "unspecified" so don't set one.
default:
nameIDFormat = string(sp.AuthnNameIDFormat)
}
Expand Down
2 changes: 1 addition & 1 deletion service_provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func TestSPCanSetAuthenticationNameIDFormat(t *testing.T) {
s.AuthnNameIDFormat = UnspecifiedNameIDFormat
req, err = s.MakeAuthenticationRequest("", HTTPRedirectBinding, HTTPPostBinding)
assert.Check(t, err)
assert.Check(t, is.Equal("", *req.NameIDPolicy.Format))
assert.Check(t, is.Equal(string(UnspecifiedNameIDFormat), *req.NameIDPolicy.Format))

// explicitly set to "emailAddress"
s.AuthnNameIDFormat = EmailAddressNameIDFormat
Expand Down