Skip to content

Conversation

@avcribl
Copy link
Contributor

@avcribl avcribl commented Jan 8, 2026

Changes:

  • Changed compression algorithm to brotli
  • Added build-version cli argument. This is long overdue, enabling us to have different binary versions for a nodejs version (in case if we introduce a new patch or anything like that)
  • Added download-url cli argument. This is very handy for R&D and testing a new binary before merging the PR. For example, I used it to build a TC and ran perf tests.

Results:

  • The brotli compression algo compresses the code to 4213141 vs what it used to be 6241709 with gzip compression algo. It's a 2MB reduction which will give us enough headroom for the future.
  • A TC was cut based on the new binary and the perf tests and regression tests were ran and no anomalies were found

@nromito
Copy link
Collaborator

nromito commented Jan 8, 2026

@avcribl is there any change in process boot times with this change?

@avcribl
Copy link
Contributor Author

avcribl commented Jan 9, 2026

@avcribl is there any change in process boot times with this change?

@nromito I did not observe any meaningful difference in boot-up times, either in docker or in the cloud. Additionally, I had done some research and did not find any indication that they have noticeable difference in decompression speed.

@ledbit ledbit merged commit d2593d7 into criblio:master Jan 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants