Skip to content

Fix vault filtering returning empty results #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cricketthomas merged 1 commit into from
Dec 12, 2025
Merged

Fix vault filtering returning empty results #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions KeyVaultExplorer/ViewModels/FilterService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ public static IList<KvSubscriptionModel> Filter(IList<KvSubscriptionModel> allSu
return allSubscriptions;
}

var filteredSubscriptions = new List<KvSubscriptionModel>();

foreach (var subscription in allSubscriptions)
{
var filteredResourceGroups = subscription.ResourceGroups
Expand All @@ -38,12 +40,12 @@ public static IList<KvSubscriptionModel> Filter(IList<KvSubscriptionModel> allSu
ResourceGroups = new ObservableCollection<KvResourceGroupModel>(filteredResourceGroups)
};

new List<KvSubscriptionModel>().Add(filteredSubscription);
filteredSubscriptions.Add(filteredSubscription);
}
}

// Sort the filtered results alphabetically
var sortedSubscriptions = SortService.SortSubscriptions(new List<KvSubscriptionModel>());
var sortedSubscriptions = SortService.SortSubscriptions(filteredSubscriptions);

// Sort the nested collections within each subscription
foreach (var subscription in sortedSubscriptions)
Expand Down
Loading