Conversation
Direct Links in job output + makefile + tests
Testing transformer engine added
Remove requirements-trfm Add to main requirements
Why not pandas
Update requirements
Ajout Multi frame Images
fmigneault
left a comment
There was a problem hiding this comment.
There's a few linting issues that can be resolved automatically using the make fix[...] targets.
Validate as well using make check[...] targets any other flagged issues that might need some manual adjustments. I didn't comment on all of them.
I did not go in depth into the actual implementation of the transform functions.
I think there is a few tests missing to validate that the actual results from each transformation is valid (eg: pixel values from one format to another are properly rendered or expected text from one format to another is properly structured).
weaver/wps_restapi/jobs/utils.py
Outdated
| output["dataType"] = dtype | ||
|
|
||
| if schema == JobInputsOutputsSchema.OGC_STRICT: | ||
| if strict: |
There was a problem hiding this comment.
This change is not valid. Removing format applies only for ogc+strict, not old+strict since "old" requires the format key.
There was a problem hiding this comment.
let me know if this change is correct
CHANGES.rst
Outdated
| - Return ``Link`` headers containing all possible output formats, allowing retrieval via query parameters | ||
| (e.g., ``/jobs/{jobId}/outputs/{id}?f=application/x-yaml``) (fixes `#18 <https://github.com/crim-ca/weaver/issues/18>`_). | ||
| - No change. |
There was a problem hiding this comment.
Add indication of the rel used for those links.
Provide one change entry about the added weaver.transforms module and a brief explanation (eg: like the other comment about the test docstring) indicating the dynamically added transform formats.
Remove the "No change" entry.
|
@Nazim-crim Details of the requirement: https://docs.ogc.org/DRAFTS/18-062r3.html#req_core_job-results-exception-no-such-output |
|
@fmigneault This should cover the different comment and fix #18 output error code. Let me know if there's other fix to applu |
(fixes
#100 <https://github.com/crim-ca/weaver/issues/100>_).GET /results/{id}andGET /outputs/{id}routes to enable direct access to individualjob result items by ID. This enhancement includes: support alternate representations based on the Accept header.
If an alternate format (e.g., YAML for a JSON source) is requested it will be automatically generated and returned.
Link headers containing all possible output formats, allowing retrieval via query parameters
(e.g., output?f=application/x-yaml). (fixes
#18 <https://github.com/crim-ca/weaver/issues/18>_).