Skip to content

Job output transform#548

Open
OlivGruwe wants to merge 104 commits intomasterfrom
job_output_transform
Open

Job output transform#548
OlivGruwe wants to merge 104 commits intomasterfrom
job_output_transform

Conversation

@OlivGruwe
Copy link

@OlivGruwe OlivGruwe commented Aug 8, 2023

  • Add support for various GeoTIFF formats, allowing flexible handling and representation of GeoTIFFs in outputs
    (fixes #100 <https://github.com/crim-ca/weaver/issues/100>_).
  • Add support for GET /results/{id} and GET /outputs/{id} routes to enable direct access to individual
    job result items by ID. This enhancement includes: support alternate representations based on the Accept header.
    If an alternate format (e.g., YAML for a JSON source) is requested it will be automatically generated and returned.
    Link headers containing all possible output formats, allowing retrieval via query parameters
    (e.g., output?f=application/x-yaml). (fixes #18 <https://github.com/crim-ca/weaver/issues/18>_).

OlivGruwe added 8 commits June 7, 2023 10:47
Direct Links in job output +
makefile +
tests
Testing transformer engine added
Remove requirements-trfm
Add to main requirements
Update requirements
Ajout Multi frame Images
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Aug 9, 2023
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few linting issues that can be resolved automatically using the make fix[...] targets.
Validate as well using make check[...] targets any other flagged issues that might need some manual adjustments. I didn't comment on all of them.

I did not go in depth into the actual implementation of the transform functions.
I think there is a few tests missing to validate that the actual results from each transformation is valid (eg: pixel values from one format to another are properly rendered or expected text from one format to another is properly structured).

@github-actions github-actions bot added feature/job Issues related to job execution, reporting and logging. feature/quotation Issues related to quotation, billing and estimators. process/builtin Issue related to builtin application processes labels Sep 24, 2024
@Nazim-crim Nazim-crim self-assigned this Sep 24, 2024
@github-actions github-actions bot added the feature/cli Issues or features related to CLI operations. label Sep 25, 2024
@Nazim-crim Nazim-crim requested a review from fmigneault March 12, 2026 15:39
output["dataType"] = dtype

if schema == JobInputsOutputsSchema.OGC_STRICT:
if strict:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not valid. Removing format applies only for ogc+strict, not old+strict since "old" requires the format key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if this change is correct

CHANGES.rst Outdated
Comment on lines 20 to 22
- Return ``Link`` headers containing all possible output formats, allowing retrieval via query parameters
(e.g., ``/jobs/{jobId}/outputs/{id}?f=application/x-yaml``) (fixes `#18 <https://github.com/crim-ca/weaver/issues/18>`_).
- No change.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add indication of the rel used for those links.

Provide one change entry about the added weaver.transforms module and a brief explanation (eg: like the other comment about the test docstring) indicating the dynamically added transform formats.

Remove the "No change" entry.

@fmigneault
Copy link
Collaborator

fmigneault commented Mar 18, 2026

@Nazim-crim
There's a few "FIXME https://github.com/crim-ca/weaver/issues/18" under https://github.com/crim-ca/weaver/blob/master/weaver/wps_restapi/api.py
In most cases, it should just be a matter of uncommenting them, but we need to check if all cases of #18 are handled (eg: calling an output that wasn't requested initially must return the http://www.opengis.net/def/exceptions/ogcapi-processes-1/1.0/no-such-output error).

Details of the requirement: https://docs.ogc.org/DRAFTS/18-062r3.html#req_core_job-results-exception-no-such-output

@Nazim-crim
Copy link
Contributor

@fmigneault This should cover the different comment and fix #18 output error code. Let me know if there's other fix to applu

@Nazim-crim Nazim-crim requested a review from fmigneault March 18, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. feature/providers Issue related to providers convertion to WPS-REST processes. feature/quotation Issues related to quotation, billing and estimators. process/builtin Issue related to builtin application processes process/wps3 Issue related to WPS 3.x (REST-JSON) processes support WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants