refactor(toHash): reduce size by using spread operator and Array.reduce#614
Open
PrettyCoffee wants to merge 1 commit intocristianbote:masterfrom
Open
refactor(toHash): reduce size by using spread operator and Array.reduce#614PrettyCoffee wants to merge 1 commit intocristianbote:masterfrom
PrettyCoffee wants to merge 1 commit intocristianbote:masterfrom
Conversation
|
@PrettyCoffee is attempting to deploy a commit to the Cristian Bote's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spreading the string into an array and using Array.reduce instead of a while loop seems to shave off 9 Bytes of the toHash function. :)