Merged
Conversation
Acknowledgements are moved into the FinishedTask typestate.
This lets us pass around `Task` instances instead of always hydrating from a task id or task model.
This is a rather big rewrite with these main changes: - A `RunningTask` now owns its `Communicator` - `State` caches `Task`s - The cache is populated lazily - Refactor and cleanup of adjacent code
This lets several requests to be served in parallel. The locking granularity is now at Task level.
The structures were basically the same. Kristian had wanted to merge them already.
Collaborator
|
Very nice, thanks for all the re-factoring work. I've done manual testing of several protocols against the client and all worked without problems. I've also read through the ARCHITECTURE.md, great to have a good starting point for understanding the server-side. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is focused on type safety and code quality. In particular, it makes these changes: