Add fetching and processing for EUCC Certificates + refactoring the rest of the pipeline#552
Open
Add fetching and processing for EUCC Certificates + refactoring the rest of the pipeline#552
Conversation
42a2a99 to
befd669
Compare
f9e6e97 to
fd9cca7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
===========================================
- Coverage 71.91% 56.97% -14.93%
===========================================
Files 76 78 +2
Lines 8834 9126 +292
===========================================
- Hits 6352 5199 -1153
- Misses 2482 3927 +1445 ☔ View full report in Codecov by Sentry. |
9b6cdf8 to
7ab8f44
Compare
tkachyna
commented
Jan 25, 2026
tkachyna
commented
Jan 25, 2026
adamjanovsky
requested changes
Jan 29, 2026
Collaborator
adamjanovsky
left a comment
There was a problem hiding this comment.
Thanks for the PR 👍 . Few notes:
- I'd say it's generally good idea to have PR and the corresponding tests in a single PR. If the tests uncover some problems, you'll be addressing them in somewhat unrelated PR which is not ideal. But proceed as you wish in this case.
- I agree that inheritance or mix-ins are not ideal in this case. The current approach is somewhat wordy but fairly easy to understand.
- I requested some minor changes here and there.
f254987 to
25f8580
Compare
Collaborator
adamjanovsky
left a comment
There was a problem hiding this comment.
There's still one more import we can get rid of. Once addressed, feel free to merge.
3401066 to
cde12ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds:
src/sec-certs/dataset/eucc.py,src/sec-certs/sample/eucc.py)Since CC and EUCC share a significantly larger portion of code compared to other datasets in the code base, using this prefix makes the intent explicit and immediately signals to developers that this logic is meant only for these two datasets.
Type safety is still preserved, ensuring that no other dataset or certificate types can be passed to the functions defined in these common files.