part 4c rel v25.9.1 #1681
Merged
part 4c rel v25.9.1 #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove pull_request_target from trigger condition (caused context mismatch) - Use workflow_run trigger exclusively for write permissions + artifact access - Add run-id parameter to download artifacts from triggering wstest workflow - Add explicit release_type == 'development' filter This enables the release-development job to: 1. Access artifacts produced by wstest.yml (via run-id) 2. Post PR comments with conformance results (via workflow_run permissions) 3. Use consistent PR context identifiers (via enhanced identifiers.yml)
Created two focused workflows:
1. release.yml (Publishing Workflow)
- Triggered by workflow_run from all 4 workflows: wheels, wheels-docker, wstest, main
- Collects artifacts from ALL workflows:
* Wheels (from wheels + wheels-docker)
* WebSocket conformance results (from wstest)
* FlatBuffers schema (from main)
- Jobs:
* release-nightly: Creates GitHub Releases for nightly + stable builds
* release-stable: Publishes to PyPI + triggers RTD build
- Runs with contents:write permission (for GitHub Releases)
- No PR comment permissions needed
2. release-post-comment.yml (PR Feedback Workflow)
- Triggered by pull_request_target (write permissions for PR comments)
- Waits for wstest workflow to complete
- Downloads wstest conformance summary
- Posts PR comment with build summary + test results
- Runs with pull-requests:write permission
- No release publishing
Benefits:
- Clear separation of concerns (publishing vs PR feedback)
- Simpler triggering logic (no complex multi-workflow coordination)
- Better security model (least privilege per workflow)
- Faster PR feedback (wstest results posted immediately)
- Complete artifact collection in releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
final round (part 4c) of CI/CD and docs improvements before rel v25.9.1
Related Issue(s)
Closes or relates to #1677
Checklist
the style guidelines of this project
is effective or that my feature works
updated the changelog
in this PR