Merged
Conversation
Fixes crossbario#102. The FlatBuffers compiler generates Python code with absolute imports like `from reflection.Type import Type` which fail when the module is vendored inside a package. Changed all 18 occurrences to use relative imports (`from .Type import Type`). Files modified: - Schema.py (4 imports) - Service.py (2 imports) - Object.py (2 imports) - Enum.py (3 imports) - EnumVal.py (1 import) - Field.py (2 imports) - RPCCall.py (3 imports) Note: This work was completed with AI assistance (Claude Code).
Addresses crossbario#102 (permanent fix for vendored flatbuffers imports): 1. Added fix-flatbuffers-reflection-imports recipe - Automatically fixes absolute imports to relative imports - Now runs automatically after generate-flatbuffers-reflection - Uses sed to convert 'from reflection.X' to 'from .X' - Verifies fix was successful 2. Added test-reflection recipe and scripts/test_reflection.py - Tests importing Schema and all 10 reflection classes - Tests loading and parsing reflection.bfbs - This is the exact use case cfxdb, wamp-xbr, and crossbar need The fix survives regeneration because generate-flatbuffers-reflection now has fix-flatbuffers-reflection-imports as a dependency. Note: This work was completed with AI assistance (Claude Code).
- Added cpy312 and cpy313 to test matrix (was: cpy311, cpy314, pypy311) - Now tests: cpy311, cpy312, cpy313, cpy314, pypy311 - Added test-reflection step to verify FlatBuffers reflection imports - This ensures crossbario#102 fix is tested on all Python versions Note: This work was completed with AI assistance (Claude Code).
Contributor
Author
|
Submodule updates: - .ai: bfb4804 -> d1647dc (polish project README) - .cicd: 024df86 -> 0954ce5 (add helper git version, fix PR template) GitHub template fixes: - Move PR template to root level (.github/pull_request_template.md) for GitHub auto-population (was in PULL_REQUEST_TEMPLATE/ subdirectory) - Remove obsolete .github/ISSUE_TEMPLATE.md (using ISSUE_TEMPLATE/ dir) Note: This work was completed with AI assistance (Claude Code).
Contributor
Author
|
works on github workflows now too, eg https://github.com/crossbario/zlmdb/actions/runs/20283952345/job/58253029147: |
Adds comprehensive documentation for FlatBuffers integration: - docs/flatbuffers/index.rst: Overview of FlatBuffers integration, explaining why FlatBuffers was chosen (zero-copy access, schema evolution, cross-language support, memory efficiency, reflection) - docs/flatbuffers/wamp-zerocopy-dataplane.rst (issue crossbario#98): Architecture and design of the zero-copy data plane for WAMP, covering data flow from LMDB through FlatBuffers to WAMP transport, design principles, and use cases - docs/flatbuffers/vendoring-design-and-technology.rst (issue crossbario#99): Technical details on native binaries, manylinux compliance, ISA compatibility, bundled flatc, and PyPy support Updates docs/index.rst to include the new flatbuffers section. Closes: crossbario#98, crossbario#99 Note: This work was completed with AI assistance (Claude Code).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #103 [WIP]