Fix/kclinput #330
Merged
Fix/kclinput #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Peefy could you plz take a look |
* make shorter lines for easier editing * fix typos * apply missing `spec` to KCLInput * remove redundant `metadata.name` from KCLInput * cspell config for spell checking Signed-off-by: Ievgenii Shepeliuk <[email protected]>
* reformat composition with yaml-language-server * remove redundant metadata.name from KCLInput * align compositions names Signed-off-by: Ievgenii Shepeliuk <[email protected]>
eshepelyuk
force-pushed
the
fix/kclinput
branch
from
6be1c99 to
667e0ab
Compare
Resolves crossplane-contrib#250 Resolves crossplane-contrib#262 Signed-off-by: Ievgenii Shepeliuk <[email protected]>
eshepelyuk
force-pushed
the
fix/kclinput
branch
from
667e0ab to
eeba587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #250
Fixes #262
I have: