Skip to content

Conversation

@bobh66
Copy link
Contributor

@bobh66 bobh66 commented Dec 18, 2025

@bobh66 bobh66 requested review from jbw976 and removed request for negz, sergenyalcin and turkenf December 18, 2025 23:19
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobh66 looks like this PR got a bunch of commits from main in its history now - do you want to clean it up (or start fresh)?

Signed-off-by: Bob Haddleton <[email protected]>
@bobh66
Copy link
Contributor Author

bobh66 commented Jan 6, 2026

@jbw976 should be squeaky clean now. Sorry about that.

@jbw976
Copy link
Member

jbw976 commented Jan 6, 2026

Also note, this was split out from #165.

@phisco @stevendborrelli please confirm you are still interested in being a maintainer on this function 🙇‍♂️

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, following up to get confirmation from @phisco and @stevendborrelli since the original PR for this #165 was awhile ago.

@stevendborrelli
Copy link
Member

Yes, I can be a code owner.

Copy link
Collaborator

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!

@jbw976 jbw976 merged commit 18fb9e7 into crossplane-contrib:main Jan 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants