Add DesiredStateChanged event filter#186
Merged
bobh66 merged 1 commit intocrossplane-contrib:mainfrom Jan 19, 2026
Merged
Conversation
turkenh
approved these changes
May 9, 2023
Member
|
This PR was never merged, but I think it’s a good fix to avoid unnecessary reconciliations. @bobh66 , would you like to rebase it and also add the same change to the modern API? After that, we can merge this branch. |
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
bobh66
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf and
ulucinar
as code owners
haarchri
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added the DesiredStateChanged() Event Filter to filter out unnecessary reconciliations
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Executed this code in a development cluster running multiple deployments.