202: Add Support for PlainHTTP for flexibility in chart downloads#255
Conversation
|
@turkenh I just ran into this issue and found this PR. What can we do to get this reviewed and merged? |
|
Thanks for this enhancement, and sorry for the long delay in reviewing it. Since it’s been a long time, could you please rebase the PR? After that, we can merge it into the main branch and include it in the next maintenance release. |
a81f62b to
b4a323b
Compare
@haarchri No problem at all. I’ve rebased the PR onto the latest main. Thanks for reviewing! Happy to see it included in the next maintenance release. |
|
thanks, can you add this too in the namespaced controller ? Since crossplane V2 we have also the apis for namespaced with extra Controllers - thanks ;) |
Signed-off-by: Ioannis Matzaris <matzarisioannis@gmail.com>
Signed-off-by: Ioannis Matzaris <matzarisioannis@gmail.com>
7b9c55e to
07137e1
Compare
|
did you rerun make generate ? missing the update in one of the CRDs |
Signed-off-by: Ioannis Matzaris <matzarisioannis@gmail.com>
good catch! I updated it here |
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @ioannis-matzaris LGTM!
Add Support for PlainHTTP
Fixes #202
helm.crossplane.io_releases.yaml) to include the new PlainHTTP field in the spec.I have:
RunThere is nomake reviewableto ensure this PR is ready for review.reviewablestep in the MakefileHow has this code been tested
package/crds/*examples/sample/release.yamlby adding an extra line after L17plainHTTP: true, without any errors. Before my changes, this line would have caused an error