Skip to content

202: Add Support for PlainHTTP for flexibility in chart downloads#255

Merged
sergenyalcin merged 3 commits intocrossplane-contrib:mainfrom
ioannis-matzaris:feature/202-Support-plain-http-options
Feb 4, 2026
Merged

202: Add Support for PlainHTTP for flexibility in chart downloads#255
sergenyalcin merged 3 commits intocrossplane-contrib:mainfrom
ioannis-matzaris:feature/202-Support-plain-http-options

Conversation

@ioannis-matzaris
Copy link
Contributor

@ioannis-matzaris ioannis-matzaris commented Dec 2, 2024

Add Support for PlainHTTP

Fixes #202

  • Added PlainHTTP, which enables insecure HTTP connections for chart downloads
    • useful in specific scenarios where secure connections are unavailable.
  • Extended support for PlainHTTP across all relevant operations:
    • Install (InstallAction)
    • Upgrade (UpgradeAction)
    • Pull (PullAction)
  • Updated CRD schema (helm.crossplane.io_releases.yaml) to include the new PlainHTTP field in the spec.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review. There is no reviewable step in the Makefile

How has this code been tested

  • manually deployed thepackage/crds/*
  • deployed the examples/sample/release.yaml by adding an extra line after L17 plainHTTP: true, without any errors. Before my changes, this line would have caused an error

@AbrohamLincoln
Copy link

@turkenh I just ran into this issue and found this PR. What can we do to get this reviewed and merged?

@haarchri
Copy link
Member

Thanks for this enhancement, and sorry for the long delay in reviewing it. Since it’s been a long time, could you please rebase the PR? After that, we can merge it into the main branch and include it in the next maintenance release.

@ioannis-matzaris
Copy link
Contributor Author

Thanks for this enhancement, and sorry for the long delay in reviewing it. Since it’s been a long time, could you please rebase the PR? After that, we can merge it into the main branch and include it in the next maintenance release.

@haarchri No problem at all. I’ve rebased the PR onto the latest main.

Thanks for reviewing! Happy to see it included in the next maintenance release.

@haarchri
Copy link
Member

haarchri commented Feb 1, 2026

thanks, can you add this too in the namespaced controller ? Since crossplane V2 we have also the apis for namespaced with extra Controllers - thanks ;)

Signed-off-by: Ioannis Matzaris <matzarisioannis@gmail.com>
Signed-off-by: Ioannis Matzaris <matzarisioannis@gmail.com>
@ioannis-matzaris ioannis-matzaris force-pushed the feature/202-Support-plain-http-options branch from 7b9c55e to 07137e1 Compare February 2, 2026 21:45
@ioannis-matzaris
Copy link
Contributor Author

thanks, can you add this too in the namespaced controller ? Since crossplane V2 we have also the apis for namespaced with extra Controllers - thanks ;)

@haarchri Thanks for your feedback. It should be also working on the namespaced controller with the 07137e1, right?

@haarchri
Copy link
Member

haarchri commented Feb 2, 2026

did you rerun make generate ? missing the update in one of the CRDs

Signed-off-by: Ioannis Matzaris <matzarisioannis@gmail.com>
@ioannis-matzaris
Copy link
Contributor Author

did you rerun make generate ? missing the update in one of the CRDs

good catch! I updated it here

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ioannis-matzaris LGTM!

@sergenyalcin sergenyalcin merged commit 94c6a4f into crossplane-contrib:main Feb 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to pull Charts from Private Registry

4 participants