add more verbose logging for provider-helm/observe.go#267
Open
wejdross wants to merge 2 commits intocrossplane-contrib:mainfrom
Open
add more verbose logging for provider-helm/observe.go#267wejdross wants to merge 2 commits intocrossplane-contrib:mainfrom
wejdross wants to merge 2 commits intocrossplane-contrib:mainfrom
Conversation
wejdross
force-pushed
the
observe/logging
branch
from
1e996b4 to
550f6e6
Compare
Author
Member
|
Thanks for this enhancement, and sorry for the long delay in reviewing it. Since it’s been a long time, could you please rebase the PR? After that, we can merge it into the main branch and include it in the next maintenance release. |
wejdross
force-pushed
the
observe/logging
branch
from
550f6e6 to
bbc31ac
Compare
wejdross
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf,
turkenh and
ulucinar
as code owners
Author
|
@haarchri Hello Christopher, I just rebased. This PR looks like a very small change, but it took me good 2 days to figure out why provider failed :) |
Member
|
Thanks can you add the Same for namespaced Release ? As we have an own controller for v2 |
Signed-off-by: wejdross <lukaszwidera1993@gmail.com>
Signed-off-by: wejdross <lukaszwidera1993@gmail.com>
wejdross
force-pushed
the
observe/logging
branch
from
48ac017 to
2d86917
Compare
Member
|
Can we decouple the build submodule update ? Log update LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Because there is no error message in observe.go when chart and release names are different it's really hard to debug what's happening and why provider-helm creates new releases every second. This PR ensures verbose message when
--debugflag is providedI have:
How has this code been tested
Testing: