docs: fix sample manifest to use providerConfigRef#281
Merged
lsviben merged 1 commit intocrossplane-contrib:mainfrom Jan 19, 2026
Merged
docs: fix sample manifest to use providerConfigRef#281lsviben merged 1 commit intocrossplane-contrib:mainfrom
lsviben merged 1 commit intocrossplane-contrib:mainfrom
Conversation
tomas-st
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf and
turkenh
as code owners
tomas-st
force-pushed
the
docs/sample-provider-config-ref
branch
from
eb04bb9 to
fe07c46
Compare
Member
|
Thanks for this enhancement, and sorry for the long delay in reviewing it. Since it’s been a long time, could you please rebase the PR? After that, we can merge it into the main branch and include it in the next maintenance release. |
Signed-off-by: Tomas Stiller <mail@tomas.de>
tomas-st
force-pushed
the
docs/sample-provider-config-ref
branch
from
fe07c46 to
306354d
Compare
haarchri
approved these changes
Jan 19, 2026
lsviben
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The sample manifest incorrectly referenced
providerRef.This update replaces it with
providerConfigRefto align with the correct usage.Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested