Open
Conversation
Signed-off-by: Caleb tenBerge <caleb.tenberge@oneidentity.com>
…ir port configurable Signed-off-by: Caleb tenBerge <caleb.tenberge@oneidentity.com>
ctenberge-oneid
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf and
turkenh
as code owners
Member
|
Thanks for this enhancement, and sorry for the long delay in reviewing it. Since it’s been a long time, could you please rebase the PR? After that, we can merge it into the main branch and include it in the next maintenance release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #274: This change adds support for configuring the ports for the webhook (see crossplane/crossplane#6291)
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I ran the provider and tested that the health probe is present and that the port is configurable. Also tested that the metrics port is configurable using
curl localhost:8080/metricsThe webhook isn't even enabled so testing is not possible. I left the code in-place for configuring the port in the future.