feat(TOOLS-6035): Update images in Dockerfiles#319
Open
oBarz wants to merge 4 commits intocrossplane-contrib:mainfrom
Open
feat(TOOLS-6035): Update images in Dockerfiles#319oBarz wants to merge 4 commits intocrossplane-contrib:mainfrom
oBarz wants to merge 4 commits intocrossplane-contrib:mainfrom
Conversation
oBarz
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf,
turkenh and
ulucinar
as code owners
Contributor
|
This looks like a private PR that escaped and made it's way upstream? I thought the proxy issue could be handled by environment variables, though I haven't tried it in a while. |
Member
|
@bobh66 if you use a single provider instance to manage many clusters in various networks, in some environments you need to talk with different proxies - if its only one Proxy true use a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the path into the Docker files for CI images to pull them from our private proxy registry.
Issue
TOOLS-6035
Documentation Review Checklist
Please refer to our Documentation overview for more information.
PR guidelines
This PR aims to comply with the Contribution Guidelines and our best practices.