Fix ignored secretRef.namespace in namespaced ProviderConfigs #323
Open
aerfio wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
Fix ignored secretRef.namespace in namespaced ProviderConfigs #323aerfio wants to merge 1 commit intocrossplane-contrib:mainfrom
secretRef.namespace in namespaced ProviderConfigs #323aerfio wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
…erconfigs Signed-off-by: Mateusz Puczyński <mateusz.puczynski@travelping.com>
aerfio
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf,
turkenh and
ulucinar
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Previous implementation overrides the
secretRef.namespacefield of the ProviderConfig, it uses the namespace of the namespaced Release object instead. I treat it as a bug, because this field is effectively ignored and useless in this case. We'd rather not copy the secret with kubeconfig to each namespace where it's consumed.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Added new unit test for the
resolveProviderConfigModernfunction.