Add aws_wafv2_web_acl_rule_group_association resource#1966
Merged
erhancagirici merged 12 commits intocrossplane-contrib:mainfrom Mar 13, 2026
Merged
Add aws_wafv2_web_acl_rule_group_association resource#1966erhancagirici merged 12 commits intocrossplane-contrib:mainfrom
erhancagirici merged 12 commits intocrossplane-contrib:mainfrom
Conversation
Matrikss
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
Signed-off-by: Bruno Loureiro <bruno.loureiro@outsystems.com>
Signed-off-by: Bruno Loureiro <bruno.loureiro@outsystems.com>
Signed-off-by: Bruno Loureiro <bruno.loureiro@outsystems.com>
Matrikss
force-pushed
the
add-waf-rule-group-association
branch
from
ade88fa to
c449e89
Compare
Contributor
Author
|
|
Signed-off-by: Bruno Loureiro <bruno.loureiro@outsystems.com>
Contributor
Author
|
Now it is really ready for review. |
…nversion paths Signed-off-by: Erhan Cagirici <erhan@upbound.io>
…t conversions Signed-off-by: Erhan Cagirici <erhan@upbound.io>
…t conversions Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Collaborator
|
/test-examples="examples/wafv2/cluster/v1beta1/webaclrulegroupassociation.yaml" |
…ions for WebACLRuleGroupAssociation Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Collaborator
|
/test-examples="examples/wafv2/cluster/v1beta1/webaclrulegroupassociation.yaml" |
erhancagirici
approved these changes
Mar 13, 2026
Collaborator
|
@Matrikss thanks for the PR 🎉 Additionally, I have manually configured the the singleton list conversions (lists with max size 1), for a cleaner API, updated the examples, and the custom external name configuration. The Uptest run - examples/wafv2/cluster/v1beta1/webaclrulegroupassociation.yaml passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds aws_wafv2_web_acl_rule_group_association resource
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Tested locally via Uptest:
