Skip to content

Add route53profiles resources (associations/profiles/resourceassociations)#1970

Merged
erhancagirici merged 8 commits intocrossplane-contrib:mainfrom
arno-pons:feat/route53profiles
Mar 12, 2026
Merged

Add route53profiles resources (associations/profiles/resourceassociations)#1970
erhancagirici merged 8 commits intocrossplane-contrib:mainfrom
arno-pons:feat/route53profiles

Conversation

@arno-pons
Copy link

@arno-pons arno-pons commented Feb 20, 2026

Description of your changes

Add support for AWS route53Profiles feature.

Fixes #1959

I have:

  • Read and followed Crossplane's contribution process.
  • Run make generate and committed the results (ideally in a separate commit).
  • Not made any manual changes to generated files, and verified this with make check-diff.

How has this code been tested

Manual testing running the controller on a kind cluster using make run and deploying:

  • a route53Profile profile testing manifest
  • a route53Profile association testing manifest

and checking that correct objects are created on AWS side

Uptest runs:

…ions)

Signed-off-by: Arnaud Pons <arnaud.pons@michelin.com>
@arno-pons arno-pons force-pushed the feat/route53profiles branch from 9a43fb5 to d149471 Compare February 20, 2026 16:58
@turkenf
Copy link
Collaborator

turkenf commented Mar 11, 2026

/test-examples="examples/route53profiles/cluster/v1beta1/association.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Mar 11, 2026

/test-examples="examples/route53profiles/cluster/v1beta1/profile.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Mar 11, 2026

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/association.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml"

Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml"

@erhancagirici erhancagirici changed the title Add route53profiles resources (associations/profiles/resourceassociat… Add route53profiles resources (associations/profiles/resourceassociations) Mar 11, 2026
@erhancagirici
Copy link
Collaborator

Note: this resource had invalid examples, which I fixed at 80f4c71

Afterwards, I realized in ResourceAssociation MR spec.forProvider.resourceArn had reference/selector fields generated (for Zone.route53 ). However, AWS API has multiple valid resource types here, so ref/selector fields should be disabled here. I'll send a change for that.

@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/association.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/profile.yaml"

…source_association

Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml,examples/route53profiles/cluster/v1beta1/association.yaml,examples/route53profiles/cluster/v1beta1/profile.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml,examples/route53profiles/cluster/v1beta1/association.yaml,examples/route53profiles/cluster/v1beta1/profile.yaml"

…ute53profiles

Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
Copy link
Collaborator

/test-examples="examples/route53profiles/cluster/v1beta1/resourceassociation.yaml,examples/route53profiles/cluster/v1beta1/association.yaml,examples/route53profiles/cluster/v1beta1/profile.yaml"

@erhancagirici erhancagirici merged commit e7ca587 into crossplane-contrib:main Mar 12, 2026
9 checks passed
@arno-pons arno-pons deleted the feat/route53profiles branch March 12, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for Route53 Profiles feature

3 participants