Skip to content

feat: add ECR Repository Creation Template support#1994

Merged
erhancagirici merged 4 commits intocrossplane-contrib:mainfrom
shdowofdeath:feat/ecr-repository-creation-template-v2
Mar 13, 2026
Merged

feat: add ECR Repository Creation Template support#1994
erhancagirici merged 4 commits intocrossplane-contrib:mainfrom
shdowofdeath:feat/ecr-repository-creation-template-v2

Conversation

@shdowofdeath
Copy link

@shdowofdeath shdowofdeath commented Mar 10, 2026

Summary

  • Add aws_ecr_repository_creation_template resource for both cluster and namespaced scopes
  • Enables automatic repository configuration for pull-through cache and replication features
  • Includes KMS key cross-reference support for encryption configuration
  • Replaces stale PR elhayef:feat/ecr-repository-creation-template support  #1857 with a clean implementation on current main

Changes Made

  • Added external name configuration (config/externalname.go)
  • Added resource to generated list (config/generated.lst)
  • Added resource configurator with KMS key reference for both cluster and namespaced ECR packages
  • Added example manifests for both scopes
  • All generated files (types, controllers, CRDs) produced by make generate

Test plan

  • make generate runs successfully and is idempotent
  • check-diff should pass (no uncommitted changes after generate)
  • check-examples should pass (examples follow correct format)
  • DCO signoff included

Fixes #1857

Uptest-examples/ecr/cluster/v1beta1/repositorycreationtemplate.yaml -- Passed

Add aws_ecr_repository_creation_template resource for both cluster and
namespaced scopes, enabling automatic repository configuration for
pull-through cache and replication features with KMS key reference support.

Signed-off-by: elhayefratdream <elhayef@dreamgroup.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@erhancagirici erhancagirici force-pushed the feat/ecr-repository-creation-template-v2 branch from b313b83 to 5422dda Compare March 13, 2026 10:18
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
Copy link
Collaborator

/test-examples="examples/ecr/cluster/v1beta1/repositorycreationtemplate.yaml"

@erhancagirici erhancagirici merged commit d6c6c20 into crossplane-contrib:main Mar 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants