build: pass all platforms at once to docker/build-push-action#3
Merged
jbw976 merged 1 commit intocrossplane:mainfrom Apr 17, 2025
Merged
build: pass all platforms at once to docker/build-push-action#3jbw976 merged 1 commit intocrossplane:mainfrom
jbw976 merged 1 commit intocrossplane:mainfrom
Conversation
Signed-off-by: Jared Watts <jbw976@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
It looks like we are not doing multi platform builds correctly right now. For example, see the manifest at https://explore.ggcr.dev/?image=xpkg.crossplane.io%2Fcrossplane%2Fchangelogs-sidecar%3Av0.0.0-20250417151805-235afa6d306d, which does not have entries for both amd64 and arm64.
The current approach is to have a matrix of architectures that each run build/push, but I think after looking at documentation like https://docs.docker.com/build/ci/github-actions/multi-platform/, we should just be passing those multiple platforms directly to the
docker/build-push-actionand let it work on them all at once.I have:
Added or updated unit tests for my change.