Tailor CodeRabbit configuration for crossplane-runtime#875
Merged
negz merged 2 commits intocrossplane:mainfrom Oct 10, 2025
Merged
Tailor CodeRabbit configuration for crossplane-runtime#875negz merged 2 commits intocrossplane:mainfrom
negz merged 2 commits intocrossplane:mainfrom
Conversation
Signed-off-by: Nic Cope <nicc@rk0n.org>
The CodeRabbit configuration was copied from the main Crossplane repository, which is an application with CLI commands, Helm charts, and E2E tests. This repository is a Go library with none of those things. This commit removes path instructions for cmd, cluster, design, test/e2e, and internal/controller directories that don't exist here. It adds pkg/reconciler path instructions instead. The breaking change check now applies to all public Go code since this is a library where all exported APIs are public. The feature gate check is removed - feature flags are implemented by library consumers, not in the library itself. Signed-off-by: Nic Cope <nicc@rk0n.org>
jbw976
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The CodeRabbit configuration was copied from the main Crossplane repository, which is an application with CLI commands, Helm charts, and E2E tests. This repository is a Go library with none of those things.
This PR removes path instructions for cmd, cluster, design, test/e2e, and internal/controller directories that don't exist here. It adds pkg/reconciler path instructions instead. The breaking change check now applies to all public Go code since this is a library where all exported APIs are public. The feature gate check is removed - feature flags are implemented by library consumers, not in the library itself.
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.