Revert "Add support for Orphan management policy"#931
Merged
phisco merged 1 commit intocrossplane:mainfrom Feb 17, 2026
Merged
Conversation
lsviben
changed the title
Contributor
📝 WalkthroughWalkthroughThis PR removes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 error)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/reconciler/managed/reconciler_legacy_test.go`:
- Line 89: The test case map contains a typo in the key
"UnpublishConnectionDetailsDeletionPolicyDeleteOrpahn"; rename this key to
"UnpublishConnectionDetailsDeletionPolicyDeleteOrphan" in the test table within
reconciler_legacy_test.go so the test name is spelled correctly (search for the
existing map entry with the incorrect key and replace it with the corrected
string); no other code logic changes are required.
| want: want{result: reconcile.Result{}}, | ||
| }, | ||
| "UnpublishConnectionDetailsDeletionPolicyDeleteOrphan": { | ||
| "UnpublishConnectionDetailsDeletionPolicyDeleteOrpahn": { |
Contributor
There was a problem hiding this comment.
Typo in test case name: "Orphahn" → "Orphan".
Hey, small catch here — it looks like a transposition crept in during the revert. The test case key reads "UnpublishConnectionDetailsDeletionPolicyDeleteOrpahn" but should be "UnpublishConnectionDetailsDeletionPolicyDeleteOrphan". Could you fix this? 🙂
🔤 Proposed fix
- "UnpublishConnectionDetailsDeletionPolicyDeleteOrpahn": {
+ "UnpublishConnectionDetailsDeletionPolicyDeleteOrphan": {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "UnpublishConnectionDetailsDeletionPolicyDeleteOrpahn": { | |
| "UnpublishConnectionDetailsDeletionPolicyDeleteOrphan": { |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pkg/reconciler/managed/reconciler_legacy_test.go` at line 89, The test case
map contains a typo in the key
"UnpublishConnectionDetailsDeletionPolicyDeleteOrpahn"; rename this key to
"UnpublishConnectionDetailsDeletionPolicyDeleteOrphan" in the test table within
reconciler_legacy_test.go so the test name is spelled correctly (search for the
existing map entry with the incorrect key and replace it with the corrected
string); no other code logic changes are required.
phisco
approved these changes
Feb 17, 2026
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 26bc05a, reversing changes made to af8c3fb.
Description of your changes
Reverts #864
Discussed with @bobh66 in Crossplane Slack. We would like to hold off on changes to management policies until we find a better aligned solution.
Ref: #930
Fixes #
I have:
./nix.sh flake checkto ensure this PR is ready for review.[ ] Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.