feat: sync protobuff with xp v2 changes #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phisco
force-pushed
the
sync-protobuff-xpv2
branch
from
5512c49 to
7b34ce9
Compare
Signed-off-by: Philippe Scorsolini <[email protected]>
phisco
force-pushed
the
sync-protobuff-xpv2
branch
from
7b34ce9 to
4f71804
Compare
negz
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Crossplane v2 introduced some backward compatible changes to the v1 protobuff schema, to allow requesting namespaced resources from functions, which is what crossplane-contrib/function-extra-resources#47 is asking for.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested