Skip to content

Conversation

@negz
Copy link
Member

@negz negz commented Oct 10, 2025

Description of your changes

The CodeRabbit configuration was copied from the main Crossplane repository, which is an application with APIs, controllers, CLI commands, and Helm charts. This repository is a focused SDK library for building composition functions with none of those things.

This PR removes path instructions for apis, internal/controller, cmd, test/e2e, cluster, and design directories that don't exist here. The error handling instruction now references function-sdk-go/errors instead of crossplane-runtime/pkg/errors. The breaking change check applies to all public Go code since this is a library where all exported APIs are public. The feature gate check is removed - feature flags are implemented by function authors, not in the SDK.

I have:

negz added 2 commits October 10, 2025 12:57
The CodeRabbit configuration was copied from the main Crossplane repository,
which is an application with APIs, controllers, CLI commands, and Helm
charts. This repository is a focused SDK library for building composition
functions with none of those things.

This commit removes path instructions for apis, internal/controller, cmd,
test/e2e, cluster, and design directories that don't exist here. The error
handling instruction now references function-sdk-go/errors instead of
crossplane-runtime/pkg/errors. The breaking change check applies to all
public Go code since this is a library where all exported APIs are public.
The feature gate check is removed - feature flags are implemented by
function authors, not in the SDK.

Signed-off-by: Nic Cope <[email protected]>
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @negz!

@negz negz merged commit 0d86067 into crossplane:main Oct 10, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants