Draft: add special marshal and unmarshal function for ResourceSelector #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avarei
changed the title
Signed-off-by: Tim <[email protected]>
avarei
force-pushed
the
fix/resourceselectorJsonUnmarshal
branch
from
a84e3ba to
606d727
Compare
Author
|
in case there is interest i am happy to revive this but at this time the solution I found in the linked issue suffices for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds custom ResourceSelector Marshal and Unmarshal functions to enable conversions from or to yaml and json.
Fixes #148
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
This code has only been partially tested in a small test project.
Since the other resources in this package are autogenerated I would like some feedback, wether I am on the right track before adding some tests.