chore(deps): bump function-sdk-go to v0.5.0 #107
Conversation
Signed-off-by: Jared Watts <[email protected]>
|
Looks like build and lint are failing in the CI environment here, will look into this ASAP edit: done, all checks are green now ✅ |
- .golangci.yml config file migrated with golangci-lint migrate Signed-off-by: Jared Watts <[email protected]>
| @@ -1,206 +1,144 @@ | |||
| run: | |||
There was a problem hiding this comment.
this file was migrated with golangci-lint migrate, using the same version of v2.4.0 as is specified in ci.yml
There was a problem hiding this comment.
I don't love that this command strips all the commentary from the file. What I've been doing is copying the one from c/c (which I migrated then re-added the commentary to) and updating the import paths.
Not a blocker though.
There was a problem hiding this comment.
that's a good suggestion, i didn't like how the comments were stripped either. i'll follow up on it and then merge this PR :)
Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
| @@ -1,206 +1,144 @@ | |||
| run: | |||
There was a problem hiding this comment.
I don't love that this command strips all the commentary from the file. What I've been doing is copying the one from c/c (which I migrated then re-added the commentary to) and updating the import paths.
Not a blocker though.
Signed-off-by: Jared Watts <[email protected]>
3 participants
Description of your changes
This PR simply bumps this template repo to use the latest function-sdk-go v0.5.0: https://github.com/crossplane/function-sdk-go/releases/tag/v0.5.0
The basic commands from the README still work to generate code, run unit tests, test with
crossplane render, and build a function package.Nothing specifically for operation functions has been added in this PR, we are focusing on bumping the SDK dependency. We can add some operations examples in the future as desired.
Fixes #103
I have: