Update golangci-lint configuration to work with latest linter versions #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
changed the title
negz
reviewed
Mar 14, 2025
.golangci.yml
Outdated
| maligned: | ||
| # print struct with more effective memory layout or not, false by default | ||
| suggest-new: true | ||
| min-complexity: 20 |
Member
There was a problem hiding this comment.
Was this supposed to change from 10 to 20?
Member
Author
There was a problem hiding this comment.
good catch, this was specific for function-azresourcegraph, will amend
* Follow golangci-lint config verify errors and fix according to the latest https://golangci-lint.run/usage/configuration/ and https://golangci-lint.run/usage/linters * It should proactively fix the associated pipeline failures Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
force-pushed
the
update-golangci-yml
branch
from
5b49bef to
115fb89
Compare
kaessert
approved these changes
Mar 14, 2025
phisco
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Follow
golangci-lint config verifyerrors and fix them according to the latest https://golangci-lint.run/usage/configuration/ and https://golangci-lint.run/usage/lintersIt should proactively fix the associated pipeline failures
Before:
After:
Originally updated in the context of upbound/function-azresourcegraph#43
I have: