-
Notifications
You must be signed in to change notification settings - Fork 149
docs: Update Kakao documentation path in README #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughREADME.md documentation was updated with refined iOS setup prerequisite links, reformatted table layouts, and minor whitespace adjustments across Android and Expo setup guidance sections. No functional code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@README.md`:
- Around line 117-125: The fenced code blocks showing keytool + openssl commands
lack language identifiers; update both code fences surrounding the commands (the
debug keystore example and the custom keystore example) to include a shell
language tag such as "bash" (i.e., change ``` to ```bash) so Markdownlint MD040
is satisfied and syntax highlighting/tooling improve.
| > ``` | ||
| > keytool -exportcert -alias androiddebugkey -keystore ~/.android/debug.keystore -storepass android -keypass android | openssl sha1 -binary | openssl base64 | ||
| > ``` | ||
| > | ||
| > **특정 경로의 keystore 에서 key hash 추출** | ||
| > | ||
| > ``` | ||
| > keytool -exportcert -alias {my-app-key-alias} -keystore {your-key-path}/{my-app-key}.keystore -storepass android -keypass android | openssl sha1 -binary | openssl base64 | ||
| > ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add language identifiers to fenced code blocks.
Markdownlint (MD040) flags these blocks; add bash (or sh) to improve readability and tooling.
Proposed fix
- > ```
+ > ```bash
> keytool -exportcert -alias androiddebugkey -keystore ~/.android/debug.keystore -storepass android -keypass android | openssl sha1 -binary | openssl base64
> ```
...
- > ```
+ > ```bash
> keytool -exportcert -alias {my-app-key-alias} -keystore {your-key-path}/{my-app-key}.keystore -storepass android -keypass android | openssl sha1 -binary | openssl base64
> ```📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| > ``` | |
| > keytool -exportcert -alias androiddebugkey -keystore ~/.android/debug.keystore -storepass android -keypass android | openssl sha1 -binary | openssl base64 | |
| > ``` | |
| > | |
| > **특정 경로의 keystore 에서 key hash 추출** | |
| > | |
| > ``` | |
| > keytool -exportcert -alias {my-app-key-alias} -keystore {your-key-path}/{my-app-key}.keystore -storepass android -keypass android | openssl sha1 -binary | openssl base64 | |
| > ``` | |
| > |
🧰 Tools
🪛 LanguageTool
[grammar] ~121-~121: Ensure spelling is correct
Context: ...nssl base64 > > > **특정 경로의 keystore 에서 key hash 추출** > > > key...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.18.1)
117-117: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
123-123: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
In `@README.md` around lines 117 - 125, The fenced code blocks showing keytool +
openssl commands lack language identifiers; update both code fences surrounding
the commands (the debug keystore example and the custom keystore example) to
include a shell language tag such as "bash" (i.e., change ``` to ```bash) so
Markdownlint MD040 is satisfied and syntax highlighting/tooling improve.
Description
This PR updates the official documentation links in
README.mdto ensure they work correctly. Specifically, it fixes the broken links for the iOS project setup guide and the Android key hash registration guide.Context
Changes
Thanks!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.