feat: Add acceptSourceChanges in request of Merge Branch API#120
Conversation
RyanCarlisle
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 97.99% 98.21% +0.23%
==========================================
Files 68 68
Lines 4213 3296 -917
==========================================
- Hits 4128 3237 -891
+ Misses 59 33 -26
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the acceptSourceChanges field in the Crowdin Merge Branch API request, addressing issue #116.
Key Changes:
- Added
AcceptSourceChangesfield toBranchesMergeRequestandBranchMergestructures - Updated test cases to verify the new field is properly serialized and deserialized
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crowdin/model/branches.go | Added AcceptSourceChanges field to both BranchMerge and BranchesMergeRequest structures with JSON tags |
| crowdin/model/branches_test.go | Updated validation test to include the new field in a valid request |
| crowdin/branches_test.go | Updated test cases to verify serialization/deserialization of AcceptSourceChanges in merge and status check operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrii-bodnar
left a comment
andrii-bodnar
left a comment
There was a problem hiding this comment.
@RyanCarlisle thank you!
|
@RyanCarlisle please also make a follow-up PR to address the missing change mentioned here - crowdin/crowdin-api-client-js#581 (review) |
|
@andrii-bodnar I've already added |
|
@RyanCarlisle I missed it, sorry for the confusion! |
|
not a problem, cheers! |
Fixes #116