Skip to content

feat: Add tmApprovedSuggestionsOnly parameter in Add Project API #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrii-bodnar merged 2 commits into from
Oct 29, 2025
Merged

feat: Add tmApprovedSuggestionsOnly parameter in Add Project API #121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88ff80b
tmApprovedSuggestionsOnly parameter in Add Project API
RyanCarlisle Oct 28, 2025
34afbd7
add TmApprovedSuggestionsOnly in Project interface
RyanCarlisle Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crowdin/model/projects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ type ProjectsAddRequest struct {
UseGlobalTM *bool `json:"useGlobalTm,omitempty"`
// If true - show primary language TM suggestions for dialects if there are no dialect-specific ones. Default: true.
ShowTMSuggestionsDialects *bool `json:"showTmSuggestionsDialects,omitempty"`
// If true - only approved suggestions will be saved to the project default TM.
TmApprovedSuggestionsOnly *bool `json:"tmApprovedSuggestionsOnly,omitempty"`
Copy link
Member

@andrii-bodnar andrii-bodnar Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Project model should also have this property because it is included in the response.

// Defines whether to skip untranslated strings.
SkipUntranslatedStrings *bool `json:"skipUntranslatedStrings,omitempty"`
// Defines whether to export only approved strings.
Expand Down
2 changes: 2 additions & 0 deletions crowdin/projects_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,6 +984,7 @@ func TestProjectsService_Add(t *testing.T) {
HiddenStringsProofreadersAccess: ToPtr(false),
UseGlobalTM: ToPtr(false),
ShowTMSuggestionsDialects: ToPtr(true),
TmApprovedSuggestionsOnly: ToPtr(false),
SkipUntranslatedStrings: ToPtr(false),
ExportApprovedOnly: ToPtr(false),
QACheckIsActive: ToPtr(false),
Expand Down Expand Up @@ -1105,6 +1106,7 @@ func TestProjectsService_Add(t *testing.T) {
"hiddenStringsProofreadersAccess": false,
"useGlobalTm": false,
"showTmSuggestionsDialects": true,
"tmApprovedSuggestionsOnly": false,
"skipUntranslatedStrings": false,
"exportApprovedOnly": false,
"qaCheckIsActive": false,
Expand Down
Loading