improve ingress nginx documentation accuracy #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
buixor
reviewed
Sep 11, 2025
buixor
reviewed
Sep 11, 2025
| controller: | ||
| image: | ||
| PullPolicy: IfNotPresent | ||
| image: crowdsecurity/controller |
Contributor
There was a problem hiding this comment.
add a comment above that line to highlight its importance ?
buixor
reviewed
Sep 11, 2025
| ``` | ||
| </details> | ||
|
|
||
| And then check if the ingress controller is running well. |
Contributor
There was a problem hiding this comment.
should we link to healthcheck ? is it relevant for that usecase ?
Contributor
Author
There was a problem hiding this comment.
not yet, will do when healthcheck will be ready
buixor
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve ingress nginx documentation accuracy