feat(*): Add missing cti fields #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation to improve clarity and adds a changelog entry for the new CTI fields.
- Updated README instruction for changing folder ownership
- Added a new release entry in the CHANGELOG documenting the added CTI fields and a minor typo fix
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dev/README.md | Updated instruction text for container folder ownership changes |
| CHANGELOG.md | Added release notes for version 1.2.0 with details on newly-added CTI fields |
Files not reviewed (3)
- .github/workflows/keepalive.yml: Language not supported
- app.manifest: Language not supported
- default/app.conf: Language not supported
|
|
||
| When the container is created, [Splunk set all permissions](https://github.com/splunk/docker-splunk/blob/develop/docs/SECURITY.md#splunk-home-ownership) to `splunk` user and group. | ||
| so you need to change the ownership of the folder to your user: | ||
| That's why you need to change the ownership of the folder to your user: |
There was a problem hiding this comment.
[nitpick] The updated instruction uses a different tone compared to the rest of the document; consider aligning its style for improved consistency.
|
|
||
| ### Added | ||
|
|
||
| - Add missing CTI fields (`reputation`, `confidence`, `mitre_techniques`, `cves`, `background_noise`, `ip_range_24`, `ip_range_24_reputation`, `ip_range_24_score`) |
There was a problem hiding this comment.
[nitpick] Consider adding additional context or a link to further documentation on the CTI fields to aid users in understanding their significance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.