leakybucket: refactor queue handling to use an interface

[sabban]

Refactored the Queue type to introduce a new Queue interface with a LocalQueue implementation and updated all references to use the new interface.

The old types.Queue is kept alive to be used in expr expressions, but only there.

For now, this PR definitely breaks the ability to load buckets from bucket state files, but I believe it wasn't in a workable state anyway. If it's worth it, I can write a Marshaller and Unmarshaller for the Leaky types to make the feature work again, if not I can clean all the state-related code. In the meantime, I even deactivated the state loading tests.

Once this PR is accepted and merged, it's possible to add a new backend for Queues.

[github-actions]

@sabban: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind refactoring
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@sabban: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[sabban]

/kind enhancement
/area agent

[codecov]

Codecov Report

❌ Patch coverage is 62.73546% with 910 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.60%. Comparing base (cf98131) to head (43e383f).
⚠️ Report is 37 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/crowdsec-cli/climachine/inspect.go	18.05%	168 Missing and 9 partials ⚠️
pkg/acquisition/modules/docker/docker.go	59.64%	94 Missing and 19 partials ⚠️
cmd/crowdsec-cli/clisetup/wizard.go	48.48%	89 Missing and 13 partials ⚠️
cmd/crowdsec-cli/clisetup/acquisition.go	48.27%	67 Missing and 8 partials ⚠️
pkg/hubtest/hubtest_item.go	0.00%	34 Missing ⚠️
cmd/crowdsec/lpmetrics.go	82.24%	21 Missing and 9 partials ⚠️
...crowdsec-cli/clisetup/setup/exprwindows_windows.go	19.35%	24 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clisetup/hub.go	72.41%	16 Missing and 8 partials ⚠️
cmd/crowdsec-cli/climetrics/store.go	5.00%	19 Missing ⚠️
cmd/crowdsec-cli/clisetup/setup/acquisition.go	73.13%	12 Missing and 6 partials ⚠️
... and 53 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
+ Coverage   60.68%   61.60%   +0.91%     
==========================================
  Files         375      405      +30     
  Lines       41345    41578     +233     
==========================================
+ Hits        25091    25613     +522     
+ Misses      14179    13855     -324     
- Partials     2075     2110      +35     

Flag	Coverage Δ
bats	45.52% <48.62%> (+0.72%)	⬆️
unit-linux	34.50% <29.60%> (+0.19%)	⬆️
unit-windows	24.34% <25.68%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.