refact pkg/apiserver: happy path; remove middleware closures

[mmetc]

No description provided.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

❌ Patch coverage is 71.23288% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.71%. Comparing base (097c242) to head (c7e59f4).

Files with missing lines	Patch %	Lines
pkg/apiserver/middlewares/v1/api_key.go	50.00%	12 Missing and 5 partials ⚠️
pkg/apiserver/controllers/v1/metrics.go	87.09%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4176      +/-   ##
==========================================
+ Coverage   35.69%   35.71%   +0.01%     
==========================================
  Files         466      466              
  Lines       33270    33265       -5     
==========================================
+ Hits        11876    11879       +3     
+ Misses      20017    20012       -5     
+ Partials     1377     1374       -3     

Flag	Coverage Δ
unit-linux	35.70% <71.23%> (+0.02%)	⬆️
unit-windows	25.00% <5.47%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.