Skip to content

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 8, 2026

no need to use MiddlewareFunc if everything needs to be run for each request

@mmetc mmetc added this to the 1.7.5 milestone Jan 8, 2026
@mmetc mmetc requested a review from sabban January 8, 2026 08:30
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 71.23288% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.69%. Comparing base (91ffe2e) to head (ebf4cd0).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/middlewares/v1/api_key.go 50.00% 12 Missing and 5 partials ⚠️
pkg/apiserver/controllers/v1/metrics.go 87.09% 2 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (91ffe2e) and HEAD (ebf4cd0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (91ffe2e) HEAD (ebf4cd0)
bats 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4186       +/-   ##
===========================================
- Coverage   62.90%   35.69%   -27.22%     
===========================================
  Files         467      466        -1     
  Lines       33274    33267        -7     
===========================================
- Hits        20932    11873     -9059     
- Misses      10216    20019     +9803     
+ Partials     2126     1375      -751     
Flag Coverage Δ
bats ?
unit-linux 35.67% <71.23%> (+0.03%) ⬆️
unit-windows 25.01% <5.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit e325e2c into master Jan 9, 2026
16 of 32 checks passed
@mmetc mmetc deleted the middleware-func branch January 9, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants