Skip to content

papi: check if decision is allowlisted before adding it #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blotus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

papi: check if decision is allowlisted before adding it #4196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions pkg/apiserver/papi_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,30 @@ func AlertCmd(ctx context.Context, message *Message, p *Papi, sync bool) error {
}

log.Infof("Received order %s from PAPI (%d decisions)", alert.UUID, len(alert.Decisions))
decisionsToKeep := make([]*models.Decision, 0)
for _, decision := range alert.Decisions {
if decision.Value == nil {
continue
}
isAllowlisted, reason, err := p.DBClient.IsAllowlisted(ctx, *decision.Value)
if err != nil {
log.Errorf("Failed to check if decision '%s' is allowlisted: %s", *decision.Value, err)
// keep the decision in case of error during allowlist check
decisionsToKeep = append(decisionsToKeep, decision)
continue
}
if isAllowlisted {
log.Infof("Decision '%s' is allowlisted, removing it (%s)", *decision.Value, reason)
continue
}
decisionsToKeep = append(decisionsToKeep, decision)
}
alert.Decisions = decisionsToKeep

if len(alert.Decisions) == 0 {
log.Infof("All decisions are allowlisted for alert %s, skipping alert creation", alert.UUID)
return nil
}

/*Fix the alert with missing mandatory items*/
if alert.StartAt == nil || *alert.StartAt == "" {
Expand Down