Skip to content

pkg/leakybucket: replace global variables with injected StateDumper #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmetc merged 4 commits into from
Jan 16, 2026

group collectors in a StateDumper{}

c386b7d
Select commit
Loading
Failed to load commit list.
Merged

pkg/leakybucket: replace global variables with injected StateDumper #4197

group collectors in a StateDumper{}
c386b7d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2026 in 1s

62.89% (target 0.00%)

View this Pull Request on Codecov

62.89% (target 0.00%)

Details

Codecov Report

❌ Patch coverage is 78.67647% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.89%. Comparing base (45ba3e8) to head (c386b7d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/leakybucket/collector.go 75.00% 3 Missing and 3 partials ⚠️
pkg/parser/collector.go 86.36% 3 Missing and 3 partials ⚠️
cmd/crowdsec/dump.go 70.58% 1 Missing and 4 partials ⚠️
cmd/crowdsec/run_in_svc_windows.go 0.00% 5 Missing ⚠️
cmd/crowdsec/win_service.go 0.00% 4 Missing ⚠️
cmd/crowdsec/crowdsec.go 88.23% 0 Missing and 2 partials ⚠️
cmd/crowdsec-cli/cliexplain/explain.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4197      +/-   ##
==========================================
- Coverage   63.42%   62.89%   -0.54%     
==========================================
  Files         451      470      +19     
  Lines       32549    33329     +780     
==========================================
+ Hits        20645    20961     +316     
- Misses       9822    10243     +421     
- Partials     2082     2125      +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov