Skip to content

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 11, 2026

we already have datasources a function parameter - there's no need to use the global, as long as we pass it again where needed

@mmetc mmetc added this to the 1.7.7 milestone Feb 11, 2026
@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.13%. Comparing base (1df2c55) to head (980ef05).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec/crowdsec.go 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4299      +/-   ##
==========================================
+ Coverage   63.11%   63.13%   +0.01%     
==========================================
  Files         473      473              
  Lines       33466    33467       +1     
==========================================
+ Hits        21123    21129       +6     
+ Misses      10222    10219       -3     
+ Partials     2121     2119       -2     
Flag Coverage Δ
bats 46.56% <70.00%> (-0.01%) ⬇️
unit-linux 36.09% <0.00%> (+0.02%) ⬆️
unit-windows 24.45% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 356d311 into master Feb 12, 2026
17 checks passed
@mmetc mmetc deleted the cmd-crowdsec-datasource branch February 12, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants